Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize character set #279

Closed
sheo0147 opened this issue Dec 14, 2016 · 2 comments
Closed

Normalize character set #279

sheo0147 opened this issue Dec 14, 2016 · 2 comments
Labels

Comments

@sheo0147
Copy link

General Issue.

Vuls imports some text data from Database such as NVD/JVN... and so on.
But Vuls code is not normalize charset before parse or store to DB and so on.

  • Normalize character set from any to Unicode when importing some text data.
  • Normalize character set to Unicode ( or selectable, but default is unicode) when outputs like Mail, Slack and so on.
@hogehuga
Copy link
Contributor

hogehuga commented Dec 14, 2016

I think the default character code is UTF-8.

As for input, I seems deal with below.

  • go-cve-dictionary: Set the output of the program to UTF8.
  • or Convert go-cve-dictionary output Charactor-code to UTF-8 with vuls

As for output, When the data of go-cve-dictionary use UTF-8 or convert to UTF-8

  • -report-mail -lang=ja needs Content-Type: text/plain; charset=utf8

Mail header require charset, because Sometimes the mail software can not identify the character code.
Other report option seems to UTF-8.

I think, if the input charactor code is unified in UTF-8, output character code will be the default UTF-8.

@hogehuga
Copy link
Contributor

I send pull request #280. It fix Content-Type header issue.
The rest, output UTF-8 charset from go-cve-dictionary when Other multi byte country data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants