Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kube-proxy optional (default to install) #776

Closed
iMartyn opened this issue Apr 27, 2018 · 8 comments
Closed

Make kube-proxy optional (default to install) #776

iMartyn opened this issue Apr 27, 2018 · 8 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@iMartyn
Copy link

iMartyn commented Apr 27, 2018

What keywords did you search in kubeadm issues before filing this one?

kube-proxy

Is this a BUG REPORT or FEATURE REQUEST?

FEATURE REQUEST

If this is a FEATURE REQUEST, please:

Kubeadm should give users a way not to install kube-proxy as it is not an essential part of kubernetes in some scenarios.

For instance, if using kube-router in "All features" mode, you have to delete kube-proxy and do cleanup.

Versions

kubeadm version (use kubeadm version): &version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.1", GitCommit:"d4ab47518836c750f9949b9e0d387f20fb92260b", GitTreeState:"clean", BuildDate:"2018-04-12T14:14:26Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Environment:

  • Kubernetes version (use kubectl version): Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:55:54Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
    Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:44:10Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

  • Cloud provider or hardware configuration: Packet.net

  • OS (e.g. from /etc/os-release): CentOS 7

  • Kernel (e.g. uname -a): 4.16.5-1.el7.elrepo.x86_64 kubeadm join on slave node fails preflight checks #1 SMP Thu Apr 26 09:54:55 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux

  • Others:

What happened?

There was no way to disable the installation of kube-proxy with kubeadm

What you expected to happen?

To be able to pass a flag to disable the installation of kube-proxy

How to reproduce it (as minimally and precisely as possible)?

kubeadm init?

Anything else we need to know?

It's not a big or high priority issue but it would make for a cleaner workflow if people do not require kube-proxy.

@detiber
Copy link
Member

detiber commented Apr 27, 2018

/assign
/kind feature
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 27, 2018
@detiber detiber added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 27, 2018
@detiber
Copy link
Member

detiber commented Jun 15, 2018

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 15, 2018
@xlgao-zju
Copy link

/assign
I will take this. Since I am not so familiar with the code of kubeadm. So any guidance will be welcomed.

@detiber
Copy link
Member

detiber commented Jun 21, 2018

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2018
@timothysc
Copy link
Member

I'm going to close this issue for 1.13 b/c we are addressing this via our promotion of phases to init.

This will allow folks to skip specific phases.
/cc @fabriziopandini

@timothysc timothysc added this to the v1.13 milestone Oct 11, 2018
@ensonic
Copy link

ensonic commented Apr 15, 2019

The milestone (https://github.com/kubernetes/kubeadm/milestone/9) is closed, where can I read about "promotion of phases to init"? https://github.com/kubernetes/kubeadm/tree/master/docs/design did not got an update for a while.

@neolit123
Copy link
Member

https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-init/#init-phases

although there is a bug when skipping the kube-proxy addon from a CP node and then joining a worker node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants