feat(nodebuilder/prune)!: Enable sampling window for light nodes #2991
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
kind:feat
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
renaynay
force-pushed
the
sampling-window
branch
from
29a7c5a
to
be5008e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2991 +/- ##
==========================================
+ Coverage 50.88% 51.06% +0.18%
==========================================
Files 168 168
Lines 11021 11040 +19
==========================================
+ Hits 5608 5638 +30
+ Misses 4915 4898 -17
- Partials 498 504 +6 ☔ View full report in Codecov by Sentry. |
vgonkivs
approved these changes
Dec 5, 2023
walldiss
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces a sampling window of 30 days' worth of seconds for light nodes. The DASer will now skip over sampling headers that fall outside this range.
I've labeled this PR as breaking as it contains a behavioural break (sampling constrained to a 30-day window rather than all historical headers).