Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unfork badger and ds-badger4 #3110

Merged
merged 3 commits into from
Jan 19, 2024
Merged

chore: unfork badger and ds-badger4 #3110

merged 3 commits into from
Jan 19, 2024

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Jan 17, 2024 •
edited

  • badger merged leak fix, so we don't need to depend on our fork
    • We still have to depend on a particular commit as it hasn't been released
  • we maintained go-ds-badger4, as there was no IPFS one. Now it exists, so we can use it and archive our go-ds-badger4

@Wondertan Wondertan self-assigned this Jan 17, 2024
ramin
ramin previously approved these changes Jan 18, 2024
View reviewed changes
vgonkivs
vgonkivs previously approved these changes Jan 18, 2024
View reviewed changes
@ramin ramin enabled auto-merge (squash) January 19, 2024 10:15
@ramin ramin dismissed stale reviews from vgonkivs and themself via 69fbef4 January 19, 2024 10:26
@ramin ramin requested review from ramin and vgonkivs January 19, 2024 10:27
@ramin ramin merged commit 65c6b65 into main Jan 19, 2024
16 of 18 checks passed
@ramin ramin deleted the migrate-badger branch January 19, 2024 10:32
renaynay pushed a commit that referenced this pull request Jan 23, 2024
@Wondertan @renaynay
chore: unfork badger and ds-badger4 (#3110)
d111f1b 
* badger merged leak fix, so we don't need to depend on our fork
* We still have to depend on a particular commit as it hasn't been
released
* we maintained go-ds-badger4, as there was no IPFS one. Now it exists,
so we can use it and archive our go-ds-badger4
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin ramin ramin approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@Wondertan Wondertan

Labels
kind:chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wondertan @ramin @vgonkivs