Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state/coreAccessor): fix txResponse #3336

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

vgonkivs
Copy link
Member

Resolves #3322

Marshaling TxResponse fails because TxResponse.Tx is not empty but does not contain respective codec for encoding using the standard json.MarshalJSON()

@vgonkivs vgonkivs added area:state Related to fetching state and state execution kind:fix Attached to bug-fixing PRs labels Apr 23, 2024
@vgonkivs vgonkivs self-assigned this Apr 23, 2024
@jcstein
Copy link
Member

jcstein commented Apr 23, 2024

I tested this branch (version output for ref) and see the same logs as I did on #3304, on a successful grant-fee tx

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good as a temporary workaround

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this temporary fix. We need a corresponding issue that tracks the core/app issue to make sure we do not forget it in node.

@Wondertan Wondertan enabled auto-merge (squash) April 25, 2024 16:33
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 44.60%. Comparing base (2469e7a) to head (0c3d786).
Report is 37 commits behind head on main.

Files Patch % Lines
state/core_access.go 22.72% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3336      +/-   ##
==========================================
- Coverage   44.83%   44.60%   -0.24%     
==========================================
  Files         265      273       +8     
  Lines       14620    15254     +634     
==========================================
+ Hits         6555     6804     +249     
- Misses       7313     7667     +354     
- Partials      752      783      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wondertan Wondertan merged commit 286a389 into celestiaorg:main Apr 25, 2024
27 checks passed
@jcstein
Copy link
Member

jcstein commented Apr 25, 2024

I'm okay with this temporary fix. We need a corresponding issue that tracks the core/app issue to make sure we do not forget it in node.

has this been made? or does it still need to be made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:state Related to fetching state and state execution kind:fix Attached to bug-fixing PRs
Projects
None yet
8 participants