Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module health report for cilium status CLI #30429

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Update module health report for cilium status CLI #30429

merged 1 commit into from
Apr 4, 2024

Conversation

derailed
Copy link
Contributor

@derailed derailed commented Jan 24, 2024 •
edited

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Currently module health messages/errors on parent scope are not reported in the CLI.

  • Ensure message/error are reported in parent health module
  • Ensure tree output is sorted

Fixes: #issue-number

Signed-off-by: Fernand Galiana fernand.galiana@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 24, 2024
@derailed
Copy link
Contributor Author

/test

@derailed derailed marked this pull request as ready for review January 25, 2024 15:21
@derailed derailed requested a review from a team as a code owner January 25, 2024 15:21
@derailed derailed requested a review from thorn3r January 25, 2024 15:21
@derailed derailed changed the title Update module health report for cilium status Update module health report for cilium status CLI Jan 25, 2024
thorn3r
thorn3r approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement!

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Feb 29, 2024
@derailed derailed removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Mar 8, 2024
@derailed
Update module health report for cilium status
df43269 
Currently module health messages/errors on parent scope are not reported
in the CLI.

- Ensure message/error are reported in parent healh module
- Ensure output is sorted

Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
@derailed derailed force-pushed the pr/derailed/module_health_cli branch from b558e75 to df43269 Compare March 8, 2024 15:40
@derailed
Copy link
Contributor Author

derailed commented Mar 8, 2024

/test

@tklauser tklauser added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Apr 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 4, 2024
@tklauser tklauser removed the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Apr 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 4, 2024
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Apr 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 4, 2024
@tklauser tklauser added this pull request to the merge queue Apr 4, 2024
Merged via the queue into cilium:main with commit 2898c7e Apr 4, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derailed @thorn3r @tklauser