k8s/utils: correctly filter out labels in StripPodSpecialLabels #31421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
kind/bug
|
/test |
tklauser
force-pushed
the
pr/tklauser/fix-strip-pod-special-labels
branch
from
a9cf6a3
to
22b6c3a
Compare
|
/test |
Filter the labels before iterating them, otherwise they are added to sanitizedLabels again. Also remove forbidden keys prefixed with io.cilium.k8s because they are already filtered out by filterPodLabels and inline the check for kubernetes namespace labels. Fixes: ed4e650 ("k8s/utils: filter out cilium-owned labels on pod update") Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/fix-strip-pod-special-labels
branch
from
22b6c3a
to
6bc7599
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This was referenced Mar 19, 2024
tklauser
added
backport-pending/1.14
tklauser
added
the
backport-pending/1.13
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter the labels before iterating them, otherwise they are added to
sanitizedLabelsagain. Also remove forbidden keys prefixed withio.cilium.k8sbecause they are already filtered out byfilterPodLabelsand inline the check for kubernetes namespace labels.Fixes: ed4e650 ("k8s/utils: filter out cilium-owned labels on pod update")