Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for BPF maps without cache to GetModel #31620

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add support for BPF maps without cache to GetModel #31620

merged 1 commit into from
Apr 10, 2024

Conversation

AwesomePatrol
Copy link
Contributor

@AwesomePatrol AwesomePatrol commented Mar 26, 2024 •
edited by joestringer

This function is called by cilium-dbg map get <map-name>. Some BPF maps (that are not managed by Go-side of cilium-agent) don't have their caches populated, so it was difficult to get this information with cilium-dbg CLI (you could still do that with bpftool)

"cilium-dbg map get ..." can now be called on BPF maps without cache

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 26, 2024
@AwesomePatrol
Dump map entries even when it doesn't have cache
c44139b 
Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
@AwesomePatrol
Copy link
Contributor Author

/test

@AwesomePatrol AwesomePatrol marked this pull request as ready for review March 27, 2024 09:11
@AwesomePatrol AwesomePatrol requested a review from a team as a code owner March 27, 2024 09:11
@AwesomePatrol AwesomePatrol requested a review from lmb March 27, 2024 09:11
@michi-covalent
Copy link
Contributor

not sure if lorenz is available to review this right now, could somebody from @cilium/loader take a look?

lmb
lmb approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the long wait.

@lmb lmb enabled auto-merge April 10, 2024 15:27
@lmb lmb added sig/loader Impacts the loading of BPF programs into the kernel. release-note/misc This PR makes changes that have no direct user impact. labels Apr 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 10, 2024
@lmb lmb added this pull request to the merge queue Apr 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Apr 10, 2024
Merged via the queue into cilium:main with commit 5130d33 Apr 10, 2024
62 checks passed
@joestringer joestringer added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Apr 10, 2024
@joestringer
Copy link
Member

Thanks for this. Heads up for two things:

  1. You can always use cilium bpf ... to dump specific maps directly from the kernel without calling through userspace
  2. I bumped the release note level up to release-note/minor and updated the changelog description, since this seems like it could be a helpful tool for users to know about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmb lmb lmb approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AwesomePatrol @michi-covalent @joestringer @lmb