Loader reconciliation preparatory changes #31773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
dylandreimerink
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
dylandreimerink
force-pushed
the
feature/loader-reconciliation-2
branch
8 times, most recently
from
63596e2
to
094dce4
Compare
|
/test |
dylandreimerink
force-pushed
the
feature/loader-reconciliation-2
branch
from
094dce4
to
2ec3fbb
Compare
|
/test |
dylandreimerink
force-pushed
the
feature/loader-reconciliation-2
branch
from
2ec3fbb
to
6e94d9f
Compare
joamaki
reviewed
Apr 9, 2024
|
/test |
dylandreimerink
force-pushed
the
feature/loader-reconciliation-2
branch
2 times, most recently
from
86afd5b
to
f16011c
Compare
|
/test |
|
/test |
lmb
approved these changes
Apr 17, 2024
tklauser
approved these changes
Apr 23, 2024
gentoo-root
approved these changes
Apr 23, 2024
tommyp1ckles
approved these changes
Apr 23, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
A few unresolved conversations that should be addressed before merging. Looks like |
ti-mo
removed
the
ready-to-merge
dylandreimerink
force-pushed
the
feature/loader-reconciliation-2
branch
from
8c4f4b5
to
4d24899
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
dylandreimerink
force-pushed
the
feature/loader-reconciliation-2
branch
from
4d24899
to
9fefcd8
Compare
This commit introduces the orchestrator package and type. The orchestrator is going to be responsible for the startup and shutdown of the datapath. Currently the loaders `Reinitialize` is responsible for creating and reconciling a lot of datapath state. This commit places the orchestrator in the call path as a proxy, this will allow us to move the logic from the loader into the orchestrator in the following commits. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
This commit modularizes the prefilter. The loader no longer creates it internally, but gets a reference to is via hive. The daemon likewise gets its reference the same way. This allows us to remove the prefilter passing from the program base owner. To preserve the existing API behavior, the prefilter now can be enabled or disabled based on settings instead of being nil when disabled. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
We have this odd layer break where the Daemon holds a mutex which lock the loader, a very low level component. As prep for an upcoming change where the loader doesn't need a reference to the Daemon, we create a new type called the CompilationLock which is just an embedded mutex. This new type can be depended on by the daemon so it can still satify interfaces required for the endpoint package. The loader can also depend on the new type directly, this allows us to remove the compilation lock getter from the base program owner. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
This commit removes the `BaseProgramOwner` interface. All values it provided can now be access via Hive. This means the loader can now function without abstracted pointers to the daemon which opens the way for us to implement reconciliation without going through the daemon. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
The orchestrator now has a Reinitialize function which only takes a context. All other types are now provided via Hive. This will make it possible in a future changeset to have the orchestrator call the loader whenever it wants to reconcile. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/loader-reconciliation-2
branch
from
9fefcd8
to
dbf28a9
Compare
dylandreimerink
removed
the
ready-to-merge
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are slowly moving towards a loader that is resilient and reconciles whenever device changes are detected. Currently we have datapath logic to detect device changes, this needs to be reported up all the way to the Daemon which then pushes Reinitilization requests all the way down to the loader. This PR contains a number of preparatory changes that will make it easier for a followup PR to make the datapath / loader reconcile without going through the daemon, based on the devices table.
This PR removes the
BaseProgramOwnerwhich was one big layer violation. All dependencies the loader needs are now passed via Hive. Only the actual Reinitialize calling still exists, which will be replaced by device based reconciliation in a followup.