egressgw: Miscellaneous minor fixes to the manager #31869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
release-note/misc
This comment was marked as outdated.
This comment was marked as outdated.
pippolo84
force-pushed
the
pr/pippolo84/egress-gateway-minor-fixes
branch
from
e778e0e
to
2a1c56c
Compare
The egw manager relies on a wait group to wait for the termination of the goroutine spawned in the start hook, but it misses the calls to its Add and Done methods. Add what is missing to properly use the wait group and be sure that the event loop goroutine will be terminated when the manager is stopped. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
removeUnusedEgressRules loops over egress policy BPF map looking for entries to be cleaned up. If the current entry is still valid, the loop goes ahead to inspect the next one. A previous refactoring removed the need for multiple nested loops. Since now there is just a single one, a `continue` is enough and is more readable than a labelled continue. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/egress-gateway-minor-fixes
branch
from
2a1c56c
to
764677e
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of minor fixes to the egress gateway manager. Refer to the individual commit messages for further details.