-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deactivated Grafana reporting in monitoring example yaml. #31989
Conversation
Commit aa14979 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission, looks good to me. As this is just an example YAML and the configuration has expected behaviour for the upstream project, we will not treat this as a security vulnerability in Cilium.
In order to accept this change, you must agree to the Developer's Certificate of Origin and signal this by adding a Signed-off-by: ...
tag to your commits (git commit --amend -s
should do the trick). For more details, see the response from the bot above.
Changes lgtm, I'll approve following fixing the commit signature |
Commits aa14979, 90217ad do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
I am sorry, did not know about that. |
Commit 433b78e does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit b4c1848 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit f975b54 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit 76e8601 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
/test |
Commit 51cb772 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Hi @mvtab , there's no need to merge the main branch into the PR each day; Cilium is a fast-moving project and you'll almost always be out-of-date with respect to the main development branch. Perhaps after a week or two it may be useful to do a rebase (not merge) but otherwise I would suggest to hold off on making further changes. If you can rebase the PR once more against the main branch to drop the merge commit + force push into this branch, then I can go and retrigger the tests again. |
Commit c5ede4c does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Signed-off-by: mvtab <mvtabilitas@protonmail.com>
Hi @joestringer, noted. Thanks. |
/test |
Change description
Added two configuration parameters to Grafana for disabling most of it's reporting capabilities. Feedback links are let on.
Testing
Tested for 12h on dev kube cluster and no report requests were noticed, while the monitoring example kept working as expected.
### ReferencesFixes: GHSA-mxv3-27mh-wcfj security advisory