Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipam: retry netlink.LinkList call when setting up ENI devices #32099

Merged
merged 1 commit into from
Apr 22, 2024
Merged

ipam: retry netlink.LinkList call when setting up ENI devices #32099

merged 1 commit into from
Apr 22, 2024

Conversation

jasonaliyetti
Copy link
Contributor

@jasonaliyetti jasonaliyetti commented Apr 19, 2024 •
edited

LinkList is prone to interrupts which are surfaced by the netlink library. This leads to stability issues when using the ENI datapath. This change makes it part of the retry loop in waitForNetlinkDevices.

Fixes: #31974

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

@jasonaliyetti
ipam: retry netlink.LinkList call when setting up ENI devices
67eed70 
LinkList is prone to interrupts which are surfaced by the netlink library.  This leads to stability issues when using the ENI datapath.  This change makes it part of the retry loop in waitForNetlinkDevices.

Fixes: cilium#31974
Signed-off-by: Jason Aliyetti <jaliyetti@gmail.com>
@jasonaliyetti jasonaliyetti requested a review from a team as a code owner April 19, 2024 23:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 19, 2024
gandro
gandro approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gandro gandro added release-note/bug This PR fixes an issue in a previous release of Cilium. area/eni Impacts ENI based IPAM. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 22, 2024
@gandro
Copy link
Member

gandro commented Apr 22, 2024

/test

@jasonaliyetti jasonaliyetti mentioned this pull request Apr 22, 2024
Open
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 22, 2024
@gandro gandro added this pull request to the merge queue Apr 22, 2024
@gandro
Copy link
Member

gandro commented Apr 22, 2024

Congratulations on your first contribution! 🚀

Merged via the queue into cilium:main with commit cf9bde5 Apr 22, 2024
63 checks passed
@jasonaliyetti
Copy link
Contributor Author

Congratulations on your first contribution! 🚀

Thanks! Anything I need to do for the backports or is that automated?

@gandro
Copy link
Member

gandro commented Apr 22, 2024 •
edited

Congratulations on your first contribution! 🚀

Thanks! Anything I need to do for the backports or is that automated?

Backports should be handled by the backporter team, nothing to do from your side. If they run in any issue, they will let you know in this PR

@jasonaliyetti jasonaliyetti deleted the cilium-31974 branch April 22, 2024 15:48
@thejar thejar mentioned this pull request Apr 22, 2024
Open
3 tasks
@gandro gandro mentioned this pull request Apr 29, 2024
Merged
18 tasks
@gandro gandro added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 29, 2024
@gandro gandro mentioned this pull request Apr 30, 2024
Merged
13 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Apr 30, 2024
@gandro gandro mentioned this pull request Apr 30, 2024
Merged
10 tasks
@gandro gandro added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 30, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels May 2, 2024
@aanm aanm mentioned this pull request May 2, 2024
Merged
This was referenced May 10, 2024
Merged
Merged
Merged
@mhofstetter mhofstetter mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

Assignees
No one assigned
Labels
area/eni Impacts ENI based IPAM. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENI setup issues in 1.15.3 on EKS using ENI datapath
2 participants
@jasonaliyetti @gandro