Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused assertion helpers #32157

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

tklauser
Copy link
Member

ExpectEndpointSummary is unused since commit d0eff29 ("test: remove RuntimePolicyEnforcement tests"). PolicyEndpointsSummary is only used by ExpectEndpointSummary and can thus be removed as well.

ExpectCiliumNotRunning is unused since commit 1827d2f ("ci: move 4.19 complexity tests to tests-datapath-verifier GHA workflow").

ExpectEndpointSummary is unused since commit d0eff29 ("test: remove
RuntimePolicyEnforcement tests"). PolicyEndpointsSummary is only used by
ExpectEndpointSummary and can thus be removed as well.

ExpectCiliumNotRunning is unused since commit 1827d2f ("ci: move
4.19 complexity tests to tests-datapath-verifier GHA workflow").

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI. labels Apr 24, 2024
@tklauser tklauser requested a review from a team as a code owner April 24, 2024 09:04
@tklauser tklauser requested a review from nebril April 24, 2024 09:04
@tklauser
Copy link
Member Author

/test

@tklauser tklauser enabled auto-merge April 24, 2024 09:04
Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 24, 2024
@tklauser tklauser added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 5aebefc Apr 24, 2024
122 checks passed
@tklauser tklauser deleted the pr/tklauser/test-cleanup branch April 24, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants