Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove hostPort dependency on BPF NodePort" #32160

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Apr 24, 2024

Reverts #32046

According to @borkmann, this PR is inaccurate.

@squeed squeed requested a review from a team as a code owner April 24, 2024 10:01
@squeed squeed requested a review from markpash April 24, 2024 10:01
@maintainer-s-little-helper
Copy link

Commit 3b18fa1 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 24, 2024
This reverts commit 94c5468.

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@maintainer-s-little-helper
Copy link

Commit 3b18fa1 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@squeed squeed added the release-note/misc This PR makes changes that have no direct user impact. label Apr 24, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 24, 2024
@squeed squeed added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Apr 24, 2024
@squeed
Copy link
Contributor Author

squeed commented Apr 24, 2024

Marking as ready-to-merge, as this reverts an hour-old commit.

@ti-mo ti-mo merged commit 3f02207 into main Apr 24, 2024
45 checks passed
@ti-mo ti-mo deleted the revert-32046-host_port branch April 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants