Modified that check burst value when run the function ValidateNetprofile #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2018 14:47
1. The burst is hard code, if want to achieve the desired performance, it's best to equal the value of bandwidth. 2. Add func ConvertBandwidth,that convert the bandwidth to bytes. 3. Modified func ValidateNetprofile. 4. Test pass on local env
|
@dseevr hi, I created a new branch and pushed it to the master, Please review ~, thanks |
dseevr
reviewed
Jun 6, 2018
contivmodel/contivModel.go
Outdated
| @@ -3457,7 +3458,8 @@ func ValidateNetprofile(obj *Netprofile) error { | |||
| return errors.New("bandwidth string invalid format") | |||
| } | |||
|
|
|||
| if obj.Burst > 10486 { | |||
| bwint64 := netutils.ConvertBandwidth(obj.Bandwidth) | |||
There was a problem hiding this comment.
Where is this function? It looks like it wasn't included in the PR, but I see it in the other PR
There was a problem hiding this comment.
The function from the netutils.ConvertBandwidth and we use it directly()。The function will be convert the Bandwidth value, and the value type is int64.
wangxf1987
commented
Jun 7, 2018
contivmodel/contivModel.go
Outdated
| @@ -3457,7 +3458,8 @@ func ValidateNetprofile(obj *Netprofile) error { | |||
| return errors.New("bandwidth string invalid format") | |||
| } | |||
|
|
|||
| if obj.Burst > 10486 { | |||
| bwint64 := netutils.ConvertBandwidth(obj.Bandwidth) | |||
There was a problem hiding this comment.
The function from the netutils.ConvertBandwidth and we use it directly()。The function will be convert the Bandwidth value, and the value type is int64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified that check burst value when run the function ValidateNetprofile
Type of fix: Bug Fix
Please describe:
it's best to equal the value of bandwidth.
TODO