To future me

electron · Oct 1, 2018 · 6daf749 · 6daf749
1 parent 741942e
commit 6daf749
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/rescle.cc b/src/rescle.cc
@@ -883,14 +883,16 @@ BOOL CALLBACK ResourceUpdater::OnEnumResourceManifest(HMODULE hModule, LPCTSTR l
   HGLOBAL hResData = LoadResource(hModule, hResInfo);
   const BYTE *pResource = (const BYTE *)LockResource(hResData);
 
+  // FIXME(zcbenz): Do a real UTF string convertion.
   int len = strlen(reinterpret_cast<const char*>(pResource));
   std::wstring manifestStringLocal(pResource, pResource + len);
-
+
+  // FIXME(zcbenz): Strip the BOM instead of doing string search.
   size_t start = manifestStringLocal.find(L"<?xml");
   if (start > 0) {
     manifestStringLocal = manifestStringLocal.substr(start);
   }
-  
+
   size_t found = manifestStringLocal.find(L"requestedExecutionLevel");
   size_t end = manifestStringLocal.find(L"uiAccess");