Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misroute when dealing multiple webservice with regex #549

Merged
merged 9 commits into from
May 28, 2024

Conversation

haitch
Copy link
Contributor

@haitch haitch commented May 25, 2024

feel pretty confident on this change: we skip regex tokens when detectWebService, but we still do regex match for each token on detectRoutes.

so there is no down side by doing extra regex match on detectWebService, and increase the score.

#548

@haitch
Copy link
Contributor Author

haitch commented May 28, 2024

I still need this one to be merged, so I can safely upgrade some legacy codebase to v3.

I did notice there is v4 branch, and I tested with v4 branch, this change are still compatible, and passing all unittest.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.72%. Comparing base (91574ed) to head (b9087ca).
Report is 28 commits behind head on v3.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3     #549      +/-   ##
==========================================
+ Coverage   69.52%   69.72%   +0.19%     
==========================================
  Files          28       28              
  Lines        1608     1625      +17     
==========================================
+ Hits         1118     1133      +15     
- Misses        415      417       +2     
  Partials       75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emicklei emicklei merged commit e5fed1c into emicklei:v3 May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants