Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang workflows for restful #550

Merged
merged 4 commits into from
May 28, 2024
Merged

Conversation

haitch
Copy link
Contributor

@haitch haitch commented May 27, 2024

No description provided.

@emicklei
Copy link
Owner

I just noticed that the tests are using Go 1.21. However, the go.mod of this package states go 1.13.

@haitch
Copy link
Contributor Author

haitch commented May 28, 2024

  1. it will still works, workflow version is higher than the go mod version, which should be fine.
  2. more of a issue is do you want this module to remain on go 1.13, golang ships pretty fast, 1.13 is already out of support, checkout https://endoflife.date/go
  3. this go mod version doesn't bother me too much, not having test on PR does bother me.

@emicklei
Copy link
Owner

  1. it will still works, workflow version is higher than the go mod version, which should be fine.

Ok.

  1. more of a issue is do you want this module to remain on go 1.13, golang ships pretty fast, 1.13 is already out of support, checkout https://endoflife.date/go

Didn't know about that. Then it is time to upgrade.

  1. this go mod version doesn't bother me too much, not having test on PR does bother me.

Agree

@emicklei emicklei merged commit 77fc969 into emicklei:v3 May 28, 2024
@haitch haitch deleted the haitao/restful-workflows branch May 28, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants