Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Backport Support Cookie Authorization #393

Merged
merged 2 commits into from
Jul 23, 2020
Merged

[Chore] Backport Support Cookie Authorization #393

merged 2 commits into from
Jul 23, 2020

Conversation

JettScythe
Copy link
Contributor

Some things to keep in mind for this PR is that while it allows cookie authorization, it doesn't support the functionality for generating a cookie file like core.

@zquestz zquestz requested review from zquestz and cpacia July 22, 2020 20:25
Copy link
Contributor

@zquestz zquestz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JettScythe
Copy link
Contributor Author

This PR is moreso a step towards future PR's.
We can add auth cookie generation as well as passing the cookiefile to bchctl as we need to 😄

@JettScythe JettScythe marked this pull request as ready for review July 23, 2020 03:21
@cpacia cpacia merged commit 5a24f00 into gcash:master Jul 23, 2020
@JettScythe JettScythe deleted the cookie-auth branch July 24, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants