Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hugo version to RSS </generator> #11692

Closed
GreenLunar opened this issue Nov 9, 2023 · 3 comments · Fixed by #12300
Closed

Add Hugo version to RSS </generator> #11692

GreenLunar opened this issue Nov 9, 2023 · 3 comments · Fixed by #12300
Labels
Feature: Embedded Template Outdated Proposal

Comments

@GreenLunar
Copy link

From: https://ftw.lol/index.xml

Notice element </generator>.

<rss xmlns:atom="http://www.w3.org/2005/Atom" version="2.0">
<channel>
<title>FTW.LOL</title>
<link>//ftw.lol/</link>
<description>Recent content on FTW.LOL</description>
<generator>Hugo -- gohugo.io</generator>
<language>en</language>
<copyright>© 2023 FTW.LOL</copyright>
<lastBuildDate>Tue, 12 Sep 2023 00:00:00 +0000</lastBuildDate>
<atom:link href="//ftw.lol/index.xml" rel="self" type="application/rss+xml"/>
<item>

So we know what version we refer to. See #11691
@jmooring
Copy link
Member

Closing. disableHugoGeneratorInject is not exposed to the templates, so there is no way for site authors to opt-out.

@jmooring
Copy link
Member

Re-open. We're already injecting Hugo -- gohugo.io. Add version doesn't hurt anything.

jmooring added a commit to jmooring/hugo that referenced this issue Mar 23, 2024
@jmooring
tpl/tplimpl: Update RSS template
60cb848 
- Use publication date for pubdate
- Include version in generator element

Closes gohugoio#3918
Closes gohugoio#11692
@jmooring jmooring mentioned this issue Mar 23, 2024
Merged
bep pushed a commit that referenced this issue Mar 30, 2024
@jmooring @bep
tpl/tplimpl: Update RSS template
f0a26cf 
- Use publication date for pubdate
- Include version in generator element

Closes #3918
Closes #11692
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Feature: Embedded Template Outdated Proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tpl/tplimpl: Update RSS template jmooring/hugo
2 participants
@jmooring @GreenLunar