Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch: Add additional Events metrics #88087

Conversation

LeonardoBoleli
Copy link
Contributor

@LeonardoBoleli LeonardoBoleli commented May 20, 2024

What is this feature?

[Add a brief description of what the feature or update does.]

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@LeonardoBoleli LeonardoBoleli requested a review from a team as a code owner May 20, 2024 13:06
@LeonardoBoleli LeonardoBoleli requested review from sarahzinger and njvrzm and removed request for a team May 20, 2024 13:06
@CLAassistant
Copy link

CLAassistant commented May 20, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LeonardoBoleli
❌ Leonardo Silva


Leonardo Silva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bmike78 bmike78 mentioned this pull request May 20, 2024
3 tasks
@idastambuk
Copy link
Contributor

Hi @LeonardoBoleli, thanks a lot for the contribution!
I notice in the docs for AWS/Events there's also a missing dimension in the NamespaceDimensionKeysMap in the same file: https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-monitoring.html
If you'd like to add it, we can merge this

@LeonardoBoleli
Copy link
Contributor Author

LeonardoBoleli commented May 20, 2024 via email

@LeonardoBoleli
Copy link
Contributor Author

image

guys, may you help me to sign in CLA? I've done all the steps right and apparently not worked...

@idastambuk
Copy link
Contributor

Hi again @LeonardoBoleli, I was actually referring to the EventSourceName dimension at the bottom of the docs, that should be added in the NamespaceDimensionKeysMap in the metrics.go file. Sorry for the confusion!

@idastambuk
Copy link
Contributor

image

guys, may you help me to sign in CLA? I've done all the steps right and apparently not worked...

Hmm, can you double check that you've signed the CLA with the same Github user that submitted the PR? This is the error Im seeing from the CLA Assistant:

Leonardo Silva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@LeonardoBoleli
Copy link
Contributor Author

Did the commit on dimensions, thanks for advice and sorry for confusions!!

@LeonardoBoleli
Copy link
Contributor Author

LeonardoSilva account is my enterprise account, i cant edit my emails, how i can remove this account link on this PR?

@LeonardoBoleli LeonardoBoleli deleted the CloudWatch/Add-additional-Events-metrics branch May 20, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants