Stop using globals for func namespaces #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
fix-data-race-when-creating-func-namespaces-1126
branch
6 times, most recently
from
8365614
to
9fea8bb
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
fix-data-race-when-creating-func-namespaces-1126
branch
from
9fea8bb
to
429c5ea
Compare
hairyhenderson
deleted the
fix-data-race-when-creating-func-namespaces-1126
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1126
There was a data race due to the use of globals here. We really don't need to use globals at all...
Signed-off-by: Dave Henderson dhenderson@gmail.com