Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing spaces #207

Merged

Conversation

stuart-c
Copy link
Contributor

To fix #205

@hairyhenderson
Copy link
Owner

@stuart-c this is OK in theory, but is it necessary to address #205? Can't you simply remove the \n like mentioned in #205 (comment) ?

@stuart-c
Copy link
Contributor Author

The reason I went with this approach is:

  • Newlines aren't valid at the end of most if not all the various env vars we are using (e.g. CONSUL_VAULT_MOUNT)
  • Many tools will add newlines to the end of files (e.g. echo '' > file will unless you remember to add -n)
  • Having a newline in the produced nonce file is nice (e.g. cat works without having to remember to add the newline on the command line)

So this change would fix the nonce problem, but also fix possible future issues where people are using say VAULT_SECRET_ID_FILE with a file with trailing newline.

@hairyhenderson
Copy link
Owner

Thanks for the explanation, @stuart-c. That makes sense to me!

@hairyhenderson hairyhenderson merged commit b34e9fb into hairyhenderson:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'client nonce mismatch' when using AWS auth with nonce
2 participants