Bump OTEL version and use OTEL's vanity import path #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
rubenvp8510
reviewed
May 25, 2020
| @@ -88,7 +88,7 @@ func configureCollector(v *viper.Viper, cfg *jaegerreceiver.Config) { | |||
| } | |||
| if cOpts.TLS.CertPath != "" && cOpts.TLS.KeyPath != "" { | |||
| cfg.Protocols["grpc"].TLSCredentials = &receiver.TLSCredentials{ | |||
| // TODO client-ca is missing in OTEL https://github.com/open-telemetry/opentelemetry-collector/issues/963 | |||
| // TODO client-ca is missing in OTEL https://go.opentelemetry.io/collector/issues/963 | |||
There was a problem hiding this comment.
The link in the comment is broken :(
|
Overall looks good to me, Just a minor comment. |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
annanay25
approved these changes
May 26, 2020
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #2256 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 219 219
Lines 10658 10658
=======================================
Hits 10248 10248
- Misses 352 353 +1
+ Partials 58 57 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay ploffay@redhat.com