[hotrod/observer_test] Switch to OpenTelemetry #4635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Aug 7, 2023
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
afzal442
force-pushed
the
replace-ot-wid-otel-hotrod
branch
from
fb73f2a
to
7adf845
Compare
yurishkuro
reviewed
Aug 8, 2023
Signed-off-by: Afzal <94980910+afzalbin64@users.noreply.github.com>
yurishkuro
previously approved these changes
Aug 10, 2023
Signed-off-by: Afzal <94980910+afzalbin64@users.noreply.github.com>
|
Thanks again. But I am wondering why our test is still failing.
…On Thu 10 Aug, 2023, 11:33 PM Yuri Shkuro ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/hotrod/pkg/tracing/rpcmetrics/observer_test.go
<#4635 (comment)>
:
> @@ -109,20 +103,17 @@ func TestTags(t *testing.T) {
key string
variant string
that means it's not used, that link is still initialization path
—
Reply to this email directly, view it on GitHub
<#4635 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWUUWLVIB3BKAZJR26MCPJDXUUO7XANCNFSM6AAAAAA3HMVMPY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
yurishkuro
reviewed
Aug 10, 2023
yurishkuro
reviewed
Aug 10, 2023
Signed-off-by: Afzal <94980910+afzalbin64@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4635 +/- ##
==========================================
- Coverage 97.06% 97.04% -0.03%
==========================================
Files 301 301
Lines 17878 17878
==========================================
- Hits 17354 17350 -4
- Misses 420 423 +3
- Partials 104 105 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Aug 11, 2023
Signed-off-by: Afzal <94980910+afzalbin64@users.noreply.github.com>
Signed-off-by: Afzal <94980910+afzalbin64@users.noreply.github.com>
yurishkuro
reviewed
Aug 11, 2023
Signed-off-by: Afzal <94980910+afzalbin64@users.noreply.github.com>
Signed-off-by: Afzal <94980910+afzalbin64@users.noreply.github.com>
yurishkuro
approved these changes
Aug 12, 2023
yurishkuro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
oteltraces and const to hotROD test fileShort description of the changes
otel tracespans const i.e.ext.SpanKind..withtrace.SpanKind..and its trace API