Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Remove support for SAMPLING_TYPE env var and 'static' value #4735

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

yurishkuro
Copy link
Member

These were deprecated in 2021 (#3302)

@yurishkuro yurishkuro requested a review from a team as a code owner September 9, 2023 01:10
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
plugin/sampling/strategystore/factory_config.go 100.00%

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit bc8711b into jaegertracing:main Sep 9, 2023
31 checks passed
@yurishkuro yurishkuro deleted the remove-sampling-type branch September 9, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant