feat(jaeger-v2): Create default config for all-in-one #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
24 tasks
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
the
changelog:exprimental
yurishkuro
added a commit
that referenced
this pull request
Oct 21, 2023
## Which problem is this PR solving? - Part of #4843 - Improvement on #4842, where all-in-one configuration was created via createDefaultConfig methods of extensions called by OTel automatically. This resulted in the memstore always being present in the config and always instantiated, which is not the desired behavior. ## Description of the changes - The cmd.RunE interceptor is changed to provide an internal value to the `--config` flag if no flag was present on cmd line - This avoids creating the collector manually, once we set the flag we always delegate back to official OTel code - The value for the config is embedded in the binary and passed using `yaml:...`, which is one of the official config providers in OTel ## How was this change tested? - Ran all-in-one manually Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In Jaeger V1 the all-in-one binary can be run without any arguments / configuration, but since
jaeger-v2is built on OTel Collector it requires a config file. This is unnecessary friction for local / development use of all-in-one.Description of the changes
How was this change tested?