Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UI placeholder more descriptive #4937

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Add some styling to the placeholder
  • Make the config substitutions directly visible
  • Add missing capabilities var

How was this change tested?

go run ./cmd/all-in-one

image

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yurishkuro yurishkuro merged commit da5e236 into jaegertracing:main Nov 9, 2023
34 checks passed
@yurishkuro yurishkuro deleted the capabilities branch November 9, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants