Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission failed on checks-run #5041

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

albertteoh
Copy link
Contributor

@albertteoh albertteoh commented Dec 26, 2023

Which problem is this PR solving?

Description of the changes

github.GithubException.GithubException: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/checks/runs#create-a-check-run"}

This is because it needs write permission on the PR check runs to provide a summary.

  • The alternative is to disable test summary in the PR checks.

How was this change tested?

  • Ran this in my fork earlier.

Checklist

Signed-off-by: Albert Teoh <albert@packsmith.io>
@albertteoh albertteoh requested a review from a team as a code owner December 26, 2023 00:41
@albertteoh albertteoh added the changelog:ci Change related to continuous integration / testing label Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a798e25) 52.59% compared to head (4e53d9d) 95.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5041       +/-   ##
===========================================
+ Coverage   52.59%   95.60%   +43.00%     
===========================================
  Files         145      319      +174     
  Lines        8599    18794    +10195     
===========================================
+ Hits         4523    17968    +13445     
+ Misses       3728      663     -3065     
+ Partials      348      163      -185     
Flag Coverage Δ
cassandra-3.x 25.61% <ø> (ø)
cassandra-4.x 25.61% <ø> (ø)
elasticsearch-5.x 19.88% <ø> (ø)
elasticsearch-6.x 19.87% <ø> (-0.02%) ⬇️
elasticsearch-7.x 20.02% <ø> (ø)
elasticsearch-8.x 20.09% <ø> (-0.02%) ⬇️
grpc-badger 19.50% <ø> (ø)
kafka 14.10% <ø> (ø)
opensearch-1.x 20.02% <ø> (ø)
opensearch-2.x 20.02% <ø> (ø)
unittests 93.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertteoh albertteoh merged commit fad13b8 into jaegertracing:main Dec 26, 2023
37 checks passed
@albertteoh albertteoh deleted the fix-publish branch December 26, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants