Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate test report collection from the main target #5061

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • When the tests fail, the target test-report is never run and thus no summary can be created

Description of the changes

  • Invoke the target from the GH workflow as an explicit if: always() step

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 29, 2023 21:42
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84e7b69) 95.55% compared to head (d9e2b3e) 95.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5061      +/-   ##
==========================================
- Coverage   95.55%   95.53%   -0.02%     
==========================================
  Files         313      313              
  Lines       18160    18160              
==========================================
- Hits        17352    17349       -3     
- Misses        647      649       +2     
- Partials      161      162       +1     
Flag Coverage Δ
cassandra-3.x 25.61% <ø> (ø)
cassandra-4.x 25.61% <ø> (ø)
elasticsearch-5.x 19.87% <ø> (-0.02%) ⬇️
elasticsearch-6.x 19.88% <ø> (ø)
elasticsearch-7.x 20.00% <ø> (-0.02%) ⬇️
elasticsearch-8.x 20.11% <ø> (ø)
grpc-badger 19.50% <ø> (ø)
kafka 14.10% <ø> (ø)
opensearch-1.x 20.02% <ø> (ø)
opensearch-2.x 20.00% <ø> (ø)
unittests 93.19% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 29, 2023
Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 5082239 into jaegertracing:main Dec 30, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants