[jaeger-v2] Add support for Badger #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
|
It's not complete yet, just want some pointers on whether I'm on the right track? |
yurishkuro
reviewed
Jan 17, 2024
yurishkuro
reviewed
Jan 17, 2024
Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5112 +/- ##
==========================================
+ Coverage 95.61% 95.63% +0.01%
==========================================
Files 324 324
Lines 18568 18590 +22
==========================================
+ Hits 17754 17778 +24
+ Misses 653 651 -2
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
yurishkuro
reviewed
Jan 20, 2024
yurishkuro
reviewed
Jan 20, 2024
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
|
|
remove unrelated changes from the PR |
akagami-harsh
force-pushed
the
implement-badger-for-v2
branch
from
d85c8c6
to
4563f42
Compare
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
akagami-harsh
changed the title
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
…harsh/jaeger into implement-badger-for-v2
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
…harsh/jaeger into implement-badger-for-v2
yurishkuro
reviewed
Jan 22, 2024
yurishkuro
reviewed
Jan 22, 2024
yurishkuro
reviewed
Jan 22, 2024
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
yurishkuro
approved these changes
Jan 22, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
reviewed
Jan 23, 2024
| @@ -34,7 +34,7 @@ jobs: | |||
| run: bash scripts/kafka-integration-test.sh -k | |||
|
|
|||
| - name: Output Kafka logs | |||
| run: docker logs "${{ job.services.kafka.id }}" | |||
| run: docker logs kafka | |||
There was a problem hiding this comment.
not related to this PR, but CI was failing repeatedly and no logs were printed. Using job.services.kafka.id is a bug, leftover from when kafka was started as part of the workflow, instead of manually.
yurishkuro
approved these changes
Jan 23, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
reviewed
Jan 23, 2024
| @@ -18,7 +18,7 @@ start_kafka() { | |||
| -e KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP=CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT \ | |||
| -e KAFKA_CFG_CONTROLLER_LISTENER_NAMES=CONTROLLER \ | |||
| -e KAFKA_CFG_INTER_BROKER_LISTENER_NAME=PLAINTEXT \ | |||
| bitnami/kafka:3.6 | |||
| bitnami/kafka:3.6.0 | |||
There was a problem hiding this comment.
unrelated change, but CI was failing for this PR, because bitnami/kafka:3.6.1 was released today and it's failing to start with
Exception in thread "main" org.apache.kafka.common.config.ConfigException: Invalid value for configuration message.max.bytes: Not a number of type INT
at org.apache.kafka.common.config.ConfigDef.parseType(ConfigDef.java:745)
at org.apache.kafka.common.config.ConfigDef.parseValue(ConfigDef.java:493)
at org.apache.kafka.common.config.ConfigDef.parse(ConfigDef.java:486)
at org.apache.kafka.common.config.AbstractConfig.<init>(AbstractConfig.java:112)
at org.apache.kafka.common.config.AbstractConfig.<init>(AbstractConfig.java:145)
at kafka.server.KafkaConfig.<init>(KafkaConfig.scala:1601)
at kafka.server.KafkaConfig.<init>(KafkaConfig.scala:1603)
at kafka.tools.StorageTool$.$anonfun$main$1(StorageTool.scala:50)
at scala.Option.flatMap(Option.scala:271)
at kafka.tools.StorageTool$.main(StorageTool.scala:50)
at kafka.tools.StorageTool.main(StorageTool.scala)
yurishkuro
approved these changes
Jan 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test