Add test for plugin/storage/grpc/shared #5197

prakrit55 · 2024-02-08T06:55:13Z

Which problem is this PR solving?

Part of #5194

Description of the changes

adding test

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: yarn lint and yarn test

Signed-off-by: Griffin <prakritimandal611@gmail.com>

plugin/storage/grpc/shared/plugin_test.go

yurishkuro · 2024-02-08T23:39:06Z

make lint

Bumps the otel group with 8 updates: | Package | From | To | | --- | --- | --- | | [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) | `1.23.0` | `1.23.1` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace](https://github.com/open-telemetry/opentelemetry-go) | `1.23.0` | `1.23.1` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go) | `1.23.0` | `1.23.1` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://github.com/open-telemetry/opentelemetry-go) | `1.23.0` | `1.23.1` | | [go.opentelemetry.io/otel/exporters/stdout/stdouttrace](https://github.com/open-telemetry/opentelemetry-go) | `1.23.0` | `1.23.1` | | [go.opentelemetry.io/otel/metric](https://github.com/open-telemetry/opentelemetry-go) | `1.23.0` | `1.23.1` | | [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) | `1.23.0` | `1.23.1` | | [go.opentelemetry.io/otel/trace](https://github.com/open-telemetry/opentelemetry-go) | `1.23.0` | `1.23.1` | Updates `go.opentelemetry.io/otel` from 1.23.0 to 1.23.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md">go.opentelemetry.io/otel's changelog</a>.</em></p> <blockquote> <h2>[1.23.1] 2024-02-07</h2> <h3>Fixed</h3> <ul> <li>Register all callbacks passed during observable instrument creation instead of just the last one multiple times in <code>go.opentelemetry.io/otel/sdk/metric</code>. (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/c5b112f31b518230277ba21cd98f4391faaec2ca"><code>c5b112f</code></a> Release v1.23.1/v0.43.2 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4892">#4892</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/11ebd19c46c39896a790db15825d7c769c52577f"><code>11ebd19</code></a> Fix callback registration bug (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> <li>See full diff in <a href="https://github.com/open-telemetry/opentelemetry-go/compare/v1.23.0...v1.23.1">compare view</a></li> </ul> </details> <br /> Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace` from 1.23.0 to 1.23.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md">go.opentelemetry.io/otel/exporters/otlp/otlptrace's changelog</a>.</em></p> <blockquote> <h2>[1.23.1] 2024-02-07</h2> <h3>Fixed</h3> <ul> <li>Register all callbacks passed during observable instrument creation instead of just the last one multiple times in <code>go.opentelemetry.io/otel/sdk/metric</code>. (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/c5b112f31b518230277ba21cd98f4391faaec2ca"><code>c5b112f</code></a> Release v1.23.1/v0.43.2 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4892">#4892</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/11ebd19c46c39896a790db15825d7c769c52577f"><code>11ebd19</code></a> Fix callback registration bug (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> <li>See full diff in <a href="https://github.com/open-telemetry/opentelemetry-go/compare/v1.23.0...v1.23.1">compare view</a></li> </ul> </details> <br /> Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` from 1.23.0 to 1.23.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md">go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc's changelog</a>.</em></p> <blockquote> <h2>[1.23.1] 2024-02-07</h2> <h3>Fixed</h3> <ul> <li>Register all callbacks passed during observable instrument creation instead of just the last one multiple times in <code>go.opentelemetry.io/otel/sdk/metric</code>. (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/c5b112f31b518230277ba21cd98f4391faaec2ca"><code>c5b112f</code></a> Release v1.23.1/v0.43.2 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4892">#4892</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/11ebd19c46c39896a790db15825d7c769c52577f"><code>11ebd19</code></a> Fix callback registration bug (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> <li>See full diff in <a href="https://github.com/open-telemetry/opentelemetry-go/compare/v1.23.0...v1.23.1">compare view</a></li> </ul> </details> <br /> Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` from 1.23.0 to 1.23.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md">go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp's changelog</a>.</em></p> <blockquote> <h2>[1.23.1] 2024-02-07</h2> <h3>Fixed</h3> <ul> <li>Register all callbacks passed during observable instrument creation instead of just the last one multiple times in <code>go.opentelemetry.io/otel/sdk/metric</code>. (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/c5b112f31b518230277ba21cd98f4391faaec2ca"><code>c5b112f</code></a> Release v1.23.1/v0.43.2 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4892">#4892</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/11ebd19c46c39896a790db15825d7c769c52577f"><code>11ebd19</code></a> Fix callback registration bug (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> <li>See full diff in <a href="https://github.com/open-telemetry/opentelemetry-go/compare/v1.23.0...v1.23.1">compare view</a></li> </ul> </details> <br /> Updates `go.opentelemetry.io/otel/exporters/stdout/stdouttrace` from 1.23.0 to 1.23.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md">go.opentelemetry.io/otel/exporters/stdout/stdouttrace's changelog</a>.</em></p> <blockquote> <h2>[1.23.1] 2024-02-07</h2> <h3>Fixed</h3> <ul> <li>Register all callbacks passed during observable instrument creation instead of just the last one multiple times in <code>go.opentelemetry.io/otel/sdk/metric</code>. (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/c5b112f31b518230277ba21cd98f4391faaec2ca"><code>c5b112f</code></a> Release v1.23.1/v0.43.2 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4892">#4892</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/11ebd19c46c39896a790db15825d7c769c52577f"><code>11ebd19</code></a> Fix callback registration bug (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> <li>See full diff in <a href="https://github.com/open-telemetry/opentelemetry-go/compare/v1.23.0...v1.23.1">compare view</a></li> </ul> </details> <br /> Updates `go.opentelemetry.io/otel/metric` from 1.23.0 to 1.23.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md">go.opentelemetry.io/otel/metric's changelog</a>.</em></p> <blockquote> <h2>[1.23.1] 2024-02-07</h2> <h3>Fixed</h3> <ul> <li>Register all callbacks passed during observable instrument creation instead of just the last one multiple times in <code>go.opentelemetry.io/otel/sdk/metric</code>. (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/c5b112f31b518230277ba21cd98f4391faaec2ca"><code>c5b112f</code></a> Release v1.23.1/v0.43.2 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4892">#4892</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/11ebd19c46c39896a790db15825d7c769c52577f"><code>11ebd19</code></a> Fix callback registration bug (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> <li>See full diff in <a href="https://github.com/open-telemetry/opentelemetry-go/compare/v1.23.0...v1.23.1">compare view</a></li> </ul> </details> <br /> Updates `go.opentelemetry.io/otel/sdk` from 1.23.0 to 1.23.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md">go.opentelemetry.io/otel/sdk's changelog</a>.</em></p> <blockquote> <h2>[1.23.1] 2024-02-07</h2> <h3>Fixed</h3> <ul> <li>Register all callbacks passed during observable instrument creation instead of just the last one multiple times in <code>go.opentelemetry.io/otel/sdk/metric</code>. (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/c5b112f31b518230277ba21cd98f4391faaec2ca"><code>c5b112f</code></a> Release v1.23.1/v0.43.2 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4892">#4892</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/11ebd19c46c39896a790db15825d7c769c52577f"><code>11ebd19</code></a> Fix callback registration bug (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> <li>See full diff in <a href="https://github.com/open-telemetry/opentelemetry-go/compare/v1.23.0...v1.23.1">compare view</a></li> </ul> </details> <br /> Updates `go.opentelemetry.io/otel/trace` from 1.23.0 to 1.23.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md">go.opentelemetry.io/otel/trace's changelog</a>.</em></p> <blockquote> <h2>[1.23.1] 2024-02-07</h2> <h3>Fixed</h3> <ul> <li>Register all callbacks passed during observable instrument creation instead of just the last one multiple times in <code>go.opentelemetry.io/otel/sdk/metric</code>. (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/c5b112f31b518230277ba21cd98f4391faaec2ca"><code>c5b112f</code></a> Release v1.23.1/v0.43.2 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4892">#4892</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-go/commit/11ebd19c46c39896a790db15825d7c769c52577f"><code>11ebd19</code></a> Fix callback registration bug (<a href="https://redirect.github.com/open-telemetry/opentelemetry-go/issues/4888">#4888</a>)</li> <li>See full diff in <a href="https://github.com/open-telemetry/opentelemetry-go/compare/v1.23.0...v1.23.1">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Griffin <prakritimandal611@gmail.com>

yurishkuro · 2024-02-09T02:34:57Z

Error: plugin/storage/grpc/shared/plugin_test.go:68:2: require-error: for error assertions use require (testifylint)
	assert.NoError(t, err)
	^
Error: plugin/storage/grpc/shared/plugin_test.go:82:2: require-error: for error assertions use require (testifylint)
	assert.NoError(t, err)
	^
Error: plugin/storage/grpc/shared/plugin_test.go:92:2: require-error: for error assertions use require (testifylint)
	assert.NoError(t, err)
	^

yurishkuro · 2024-02-09T02:35:54Z

plugin/storage/grpc/shared/plugin_test.go

+type mockStorageGRPCPlugin struct {
+	spanReader *spanStoreMocks.Reader
+	spanWriter *spanStoreMocks.Writer
+	depsReader *dependencyStoreMocks.Reader
+}
+
+type mockArchiveStoragePlugin struct {
+	archiveReader *spanStoreMocks.Reader
+	archiveWriter *spanStoreMocks.Writer
+}
+
+type mockStreamingSpanWriterPlugin struct {
+	streamWriter *spanStoreMocks.Writer
+}


Since you never initialize the fields in these structs, you could've declared an empty dummy struct and define all functions on it returning nil

hey @yurishkuro, didn't understand this...I got File is not goimports-ed with -local github.com/jaegertracing/jaeger (goimports) "github.com/crossdock/crossdock-go/assert"

after using assert and require both

you need to use stretchr/testify/require, not crossdock

codecov · 2024-02-09T02:39:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b63ba63) 94.42% compared to head (f73fe38) 94.42%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5197      +/-   ##
==========================================
- Coverage   94.42%   94.42%   -0.01%     
==========================================
  Files         332      332              
  Lines       19189    19189              
==========================================
- Hits        18120    18119       -1     
  Misses        882      882              
- Partials      187      188       +1

Flag	Coverage Δ
cassandra-3.x	`25.58% <ø> (ø)`
cassandra-4.x	`25.58% <ø> (+20.32%)`	⬆️
elasticsearch-5.x	`19.86% <ø> (ø)`
elasticsearch-6.x	`19.86% <ø> (ø)`
elasticsearch-7.x	`20.00% <ø> (+0.01%)`	⬆️
elasticsearch-8.x	`20.07% <ø> (-0.02%)`	⬇️
grpc-badger	`19.50% <ø> (+0.01%)`	⬆️
kafka	`14.09% <ø> (ø)`
opensearch-1.x	`19.98% <ø> (ø)`
opensearch-2.x	`19.98% <ø> (-0.02%)`	⬇️
unittests	`92.27% <ø> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yurishkuro · 2024-02-14T17:47:54Z

please undo all *.pb.go changes, they are not related to testing

yurishkuro · 2024-02-14T17:48:44Z

None of the generated files should be in this PR.

prakrit55 · 2024-02-14T17:50:16Z

None of the generated files should be in this PR.

omg I didnt see that sorry

Signed-off-by: Griffin <prakritimandal611@gmail.com>

yurishkuro · 2024-02-14T18:56:03Z

plugin/storage/grpc/shared/plugin_test.go:9: File is not goimports-ed with -local github.com/jaegertracing/jaeger (goimports)

prakrit55 · 2024-02-14T19:00:51Z

plugin/storage/grpc/shared/plugin_test.go:9: File is not goimports-ed with -local github.com/jaegertracing/jaeger (goimports)

what would be the fix..... the line at 9 is empty

plugin/storage/grpc/shared/plugin_test.go

Signed-off-by: Griffin <prakritimandal611@gmail.com>

…31709) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/jaegertracing/jaeger](https://togithub.phpd.cn/jaegertracing/jaeger) | `v1.54.0` -> `v1.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fjaegertracing%2fjaeger/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fjaegertracing%2fjaeger/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fjaegertracing%2fjaeger/v1.54.0/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fjaegertracing%2fjaeger/v1.54.0/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jaegertracing/jaeger (github.com/jaegertracing/jaeger)</summary> ### [`v1.55.0`](https://togithub.phpd.cn/jaegertracing/jaeger/releases/tag/v1.55.0): Release 1.55.0 [Compare Source](https://togithub.phpd.cn/jaegertracing/jaeger/compare/v1.54.0...v1.55.0) ##### Backend Changes ##### ✨ New Features: - Support uploading traces to UI in OpenTelemetry format (OTLP/JSON) ([@NavinShrinivas](https://togithub.phpd.cn/NavinShrinivas) in [#5155](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5155)) - Add Elasticsearch storage support for adaptive sampling ([@Pushkarm029](https://togithub.phpd.cn/Pushkarm029) in [#5158](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5158)) ##### 🐞 Bug fixes, Minor Improvements: - Add the `print-config` subcommand ([@gmafrac](https://togithub.phpd.cn/gmafrac) in [#5200](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5200)) - Return more detailed errors from ES storage ([@yurishkuro](https://togithub.phpd.cn/yurishkuro) in [#5209](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5209)) - Bump go version ([@yurishkuro](https://togithub.phpd.cn/yurishkuro) in [#5180](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5180)) ##### 🚧 Experimental Features: - \[jaeger-v2] Add support for gRPC storarge ([@james-ryans](https://togithub.phpd.cn/james-ryans) in [#5228](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5228)) - \[jaeger-v2] Add support for Elasticsearch ([@akagami-harsh](https://togithub.phpd.cn/akagami-harsh) in [#5152](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5152)) ##### 📊 UI Changes - UI pinned to version [1.39.0](https://togithub.phpd.cn/jaegertracing/jaeger-ui/blob/main/CHANGELOG.md#v1390-2024-03-04). ##### 👏 New Contributors - [@h4shk4t](https://togithub.phpd.cn/h4shk4t) made their first contribution in [jaegertracing/jaeger#5162 - [@NavinShrinivas](https://togithub.phpd.cn/NavinShrinivas) made their first contribution in [jaegertracing/jaeger#5155 - [@prakrit55](https://togithub.phpd.cn/prakrit55) made their first contribution in [jaegertracing/jaeger#5197 - [@gmafrac](https://togithub.phpd.cn/gmafrac) made their first contribution in [jaegertracing/jaeger#5200 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

…pen-telemetry#31709) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/jaegertracing/jaeger](https://togithub.phpd.cn/jaegertracing/jaeger) | `v1.54.0` -> `v1.55.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fjaegertracing%2fjaeger/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fjaegertracing%2fjaeger/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fjaegertracing%2fjaeger/v1.54.0/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fjaegertracing%2fjaeger/v1.54.0/v1.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jaegertracing/jaeger (github.com/jaegertracing/jaeger)</summary> ### [`v1.55.0`](https://togithub.phpd.cn/jaegertracing/jaeger/releases/tag/v1.55.0): Release 1.55.0 [Compare Source](https://togithub.phpd.cn/jaegertracing/jaeger/compare/v1.54.0...v1.55.0) ##### Backend Changes ##### ✨ New Features: - Support uploading traces to UI in OpenTelemetry format (OTLP/JSON) ([@&open-telemetry#8203;NavinShrinivas](https://togithub.phpd.cn/NavinShrinivas) in [#&open-telemetry#8203;5155](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5155)) - Add Elasticsearch storage support for adaptive sampling ([@&open-telemetry#8203;Pushkarm029](https://togithub.phpd.cn/Pushkarm029) in [#&open-telemetry#8203;5158](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5158)) ##### 🐞 Bug fixes, Minor Improvements: - Add the `print-config` subcommand ([@&open-telemetry#8203;gmafrac](https://togithub.phpd.cn/gmafrac) in [#&open-telemetry#8203;5200](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5200)) - Return more detailed errors from ES storage ([@&open-telemetry#8203;yurishkuro](https://togithub.phpd.cn/yurishkuro) in [#&open-telemetry#8203;5209](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5209)) - Bump go version ([@&open-telemetry#8203;yurishkuro](https://togithub.phpd.cn/yurishkuro) in [#&open-telemetry#8203;5180](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5180)) ##### 🚧 Experimental Features: - \[jaeger-v2] Add support for gRPC storarge ([@&open-telemetry#8203;james-ryans](https://togithub.phpd.cn/james-ryans) in [#&open-telemetry#8203;5228](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5228)) - \[jaeger-v2] Add support for Elasticsearch ([@&open-telemetry#8203;akagami-harsh](https://togithub.phpd.cn/akagami-harsh) in [#&open-telemetry#8203;5152](https://togithub.phpd.cn/jaegertracing/jaeger/pull/5152)) ##### 📊 UI Changes - UI pinned to version [1.39.0](https://togithub.phpd.cn/jaegertracing/jaeger-ui/blob/main/CHANGELOG.md#v1390-2024-03-04). ##### 👏 New Contributors - [@&open-telemetry#8203;h4shk4t](https://togithub.phpd.cn/h4shk4t) made their first contribution in [jaegertracing/jaeger#5162 - [@&open-telemetry#8203;NavinShrinivas](https://togithub.phpd.cn/NavinShrinivas) made their first contribution in [jaegertracing/jaeger#5155 - [@&open-telemetry#8203;prakrit55](https://togithub.phpd.cn/prakrit55) made their first contribution in [jaegertracing/jaeger#5197 - [@&open-telemetry#8203;gmafrac](https://togithub.phpd.cn/gmafrac) made their first contribution in [jaegertracing/jaeger#5200 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

prakrit55 requested a review from a team as a code owner February 8, 2024 06:55

prakrit55 requested a review from pavolloffay February 8, 2024 06:55

adding test for ./plugin/storage/grpc/shared

2b25699

Signed-off-by: Griffin <prakritimandal611@gmail.com>

prakrit55 force-pushed the code-cov-96% branch from 06c35df to 2b25699 Compare February 8, 2024 15:18

Merge branch 'main' into code-cov-96%

3652e6e

yurishkuro reviewed Feb 8, 2024

View reviewed changes

plugin/storage/grpc/shared/plugin_test.go Outdated Show resolved Hide resolved

yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Feb 8, 2024

dependabot bot and others added 3 commits February 9, 2024 07:35

update

100257d

Signed-off-by: Griffin <prakritimandal611@gmail.com>

Merge branch 'jaegertracing:main' into code-cov-96%

bd47cfe

yurishkuro reviewed Feb 9, 2024

View reviewed changes

added github.com/stretchr/testify/require

02565ec

Signed-off-by: Griffin <prakritimandal611@gmail.com>

prakrit55 force-pushed the code-cov-96% branch from 70ef4eb to 02565ec Compare February 14, 2024 17:59

Merge branch 'main' into code-cov-96%

abb0e21

yurishkuro reviewed Feb 14, 2024

View reviewed changes

plugin/storage/grpc/shared/plugin_test.go Outdated Show resolved Hide resolved

modified

f73fe38

Signed-off-by: Griffin <prakritimandal611@gmail.com>

yurishkuro approved these changes Feb 14, 2024

View reviewed changes

yurishkuro merged commit 5375e1e into jaegertracing:main Feb 14, 2024
34 of 35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for plugin/storage/grpc/shared #5197

Add test for plugin/storage/grpc/shared #5197

prakrit55 commented Feb 8, 2024 •

edited

yurishkuro commented Feb 8, 2024

yurishkuro commented Feb 9, 2024

yurishkuro Feb 9, 2024

prakrit55 Feb 9, 2024

yurishkuro Feb 9, 2024 •

edited

codecov bot commented Feb 9, 2024 •

edited

yurishkuro commented Feb 14, 2024

yurishkuro commented Feb 14, 2024

prakrit55 commented Feb 14, 2024

yurishkuro commented Feb 14, 2024

prakrit55 commented Feb 14, 2024

Add test for plugin/storage/grpc/shared #5197

Add test for plugin/storage/grpc/shared #5197

Conversation

prakrit55 commented Feb 8, 2024 • edited

Which problem is this PR solving?

Description of the changes

Checklist

yurishkuro commented Feb 8, 2024

yurishkuro commented Feb 9, 2024

yurishkuro Feb 9, 2024

Choose a reason for hiding this comment

prakrit55 Feb 9, 2024

Choose a reason for hiding this comment

yurishkuro Feb 9, 2024 • edited

Choose a reason for hiding this comment

codecov bot commented Feb 9, 2024 • edited

Codecov Report

yurishkuro commented Feb 14, 2024

yurishkuro commented Feb 14, 2024

prakrit55 commented Feb 14, 2024

yurishkuro commented Feb 14, 2024

prakrit55 commented Feb 14, 2024

prakrit55 commented Feb 8, 2024 •

edited

yurishkuro Feb 9, 2024 •

edited

codecov bot commented Feb 9, 2024 •

edited