refactor: remove function genNatGwDeployment's return error

kubeovn · Apr 28, 2021 · 686681e · 686681e
1 parent a947ebe
commit 686681e
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/pkg/controller/vpc_nat_gateway.go b/pkg/controller/vpc_nat_gateway.go
@@ -257,10 +257,7 @@ func (c *Controller) handleAddOrUpdateVpcNatGw(key string) error {
 		}
 	}
 
-	newDp, err := c.genNatGwDeployment(gw)
-	if err != nil {
-		return err
-	}
+	newDp := c.genNatGwDeployment(gw)
 
 	if needToCreate {
 		_, err := c.config.KubeClient.AppsV1().Deployments(c.config.PodNamespace).
@@ -687,7 +684,7 @@ func (c *Controller) execNatGwRules(pod *corev1.Pod, operation string, rules []s
 	return nil
 }
 
-func (c *Controller) genNatGwDeployment(gw *kubeovnv1.VpcNatGateway) (dp *v1.Deployment, err error) {
+func (c *Controller) genNatGwDeployment(gw *kubeovnv1.VpcNatGateway) (dp *v1.Deployment) {
 	replicas := int32(1)
 	name := genNatGwDpName(gw.Name)
 	allowPrivilegeEscalation := true