do not set subnet's vlan empty on failure (#2445)

kubeovn · Mar 10, 2023 · 694059c · 694059c
1 parent 0013484
commit 694059c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/controller/subnet.go b/pkg/controller/subnet.go
@@ -268,8 +268,9 @@ func formatSubnet(subnet *kubeovnv1.Subnet, c *Controller) error {
 		}
 		if subnet.Spec.Vlan != "" {
 			if _, err := c.vlansLister.Get(subnet.Spec.Vlan); err != nil {
-				klog.Warningf("subnet %s reference a none exist vlan %s", subnet.Name, subnet.Spec.Vlan)
-				subnet.Spec.Vlan = ""
+				err = fmt.Errorf("failed to get vlan %s: %s", subnet.Spec.Vlan, err)
+				klog.Error(err)
+				return err
 			}
 		}
 	}