ci: do not push image when pr

kubeovn · Jun 12, 2020 · b27d754 · b27d754
1 parent faa8d82
commit b27d754
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/build-arm64-image.yaml b/.github/workflows/build-arm64-image.yaml
@@ -26,12 +26,13 @@ jobs:
           go get -u github.com/securego/gosec/cmd/gosec
           make release-arm
       - name: Push
+        if: ${{ github.ref == 'refs/heads/master' }}
         env:
           DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
           DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
         run: |
           TAG=$(cat VERSION)
-          docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
+          echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
           docker images
           docker tag kubeovn/kube-ovn:$TAG kubeovn/kube-ovn:$TAG-arm
           docker push kubeovn/kube-ovn:$TAG-arm
diff --git a/.github/workflows/build-x86-image.yaml b/.github/workflows/build-x86-image.yaml
@@ -62,6 +62,7 @@ jobs:
           make e2e
 
       - name: Push
+        if: ${{ github.ref == 'refs/heads/master' }}
         env:
           DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
           DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
@@ -70,6 +71,6 @@ jobs:
         run: |
           cat VERSION
           TAG=$(cat VERSION)
-          docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
+          echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
           docker images
           docker push kubeovn/kube-ovn:$TAG