Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pure arm64 build target #4044

Merged
merged 1 commit into from
May 20, 2024
Merged

add pure arm64 build target #4044

merged 1 commit into from
May 20, 2024

Conversation

bobz965
Copy link
Collaborator

@bobz965 bobz965 commented May 17, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@bobz965 bobz965 marked this pull request as ready for review May 17, 2024 09:41
@bobz965 bobz965 requested a review from zhangzujian May 17, 2024 09:41
@zhangzujian
Copy link
Member

.PHONY: release-arm
release-arm: release-arm-debug build-go-arm
	docker buildx build --platform linux/arm64 -t $(REGISTRY)/kube-ovn:$(RELEASE_TAG) --build-arg VERSION=$(RELEASE_TAG) -o type=docker -f dist/images/Dockerfile dist/images/
	docker buildx build --platform linux/arm64 -t $(REGISTRY)/vpc-nat-gateway:$(RELEASE_TAG) -o type=docker -f dist/images/vpcnatgateway/Dockerfile dist/images/vpcnatgateway

can be simplified:

.PHONY: release-arm
release-arm: release-arm-debug image-kube-ovn-arm64
	docker buildx build --platform linux/arm64 -t $(REGISTRY)/vpc-nat-gateway:$(RELEASE_TAG) -o type=docker -f dist/images/vpcnatgateway/Dockerfile dist/images/vpcnatgateway

Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
@bobz965
Copy link
Collaborator Author

bobz965 commented May 20, 2024

.PHONY: release-arm
release-arm: release-arm-debug build-go-arm
	docker buildx build --platform linux/arm64 -t $(REGISTRY)/kube-ovn:$(RELEASE_TAG) --build-arg VERSION=$(RELEASE_TAG) -o type=docker -f dist/images/Dockerfile dist/images/
	docker buildx build --platform linux/arm64 -t $(REGISTRY)/vpc-nat-gateway:$(RELEASE_TAG) -o type=docker -f dist/images/vpcnatgateway/Dockerfile dist/images/vpcnatgateway

can be simplified:

.PHONY: release-arm
release-arm: release-arm-debug image-kube-ovn-arm64
	docker buildx build --platform linux/arm64 -t $(REGISTRY)/vpc-nat-gateway:$(RELEASE_TAG) -o type=docker -f dist/images/vpcnatgateway/Dockerfile dist/images/vpcnatgateway

ok

@bobz965 bobz965 merged commit e907ec5 into kubeovn:master May 20, 2024
62 checks passed
@bobz965 bobz965 deleted the fix-ovn-dnat branch May 20, 2024 02:24
bobz965 added a commit that referenced this pull request May 20, 2024
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants