add back test DB methods that are needed for teardown #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds back a couple of methods on the wrappedSqliteClient in pkg/sql/testing that were there to prevent a panic due to double closing. These were accidentally removed in a previous commit. This also removes an exported function that was mistakenly added in the last commit as well, UnmarshalSchema. There is already a deserialize method that also converts to the engine/type.Schema type. Lastly, it fixes a compile error on one acceptance test file. Gavin is actually fixing them properly, but the intent of the last commit was to stop all the build errors.
|
Kudos, SonarCloud Quality Gate passed!
|
brennanjl
approved these changes
Aug 10, 2023
brennanjl
pushed a commit
that referenced
this pull request
Feb 26, 2024
This adds back a couple of methods on the wrappedSqliteClient in pkg/sql/testing that were there to prevent a panic due to double closing. These were accidentally removed in a previous commit. This also removes an exported function that was mistakenly added in the last commit as well, UnmarshalSchema. There is already a deserialize method that also converts to the engine/type.Schema type. Lastly, it fixes a compile error on one acceptance test file. Gavin is actually fixing them properly, but the intent of the last commit was to stop all the build errors. Co-authored-by: Jonathan Chappelow <jonathan.chappelow@gmail.com>
brennanjl
pushed a commit
that referenced
this pull request
Feb 26, 2024
This adds back a couple of methods on the wrappedSqliteClient in pkg/sql/testing that were there to prevent a panic due to double closing. These were accidentally removed in a previous commit. This also removes an exported function that was mistakenly added in the last commit as well, UnmarshalSchema. There is already a deserialize method that also converts to the engine/type.Schema type. Lastly, it fixes a compile error on one acceptance test file. Gavin is actually fixing them properly, but the intent of the last commit was to stop all the build errors. Co-authored-by: Jonathan Chappelow <jonathan.chappelow@gmail.com>
jchappelow
added a commit
that referenced
this pull request
Feb 26, 2024
This adds back a couple of methods on the wrappedSqliteClient in pkg/sql/testing that were there to prevent a panic due to double closing. These were accidentally removed in a previous commit. This also removes an exported function that was mistakenly added in the last commit as well, UnmarshalSchema. There is already a deserialize method that also converts to the engine/type.Schema type. Lastly, it fixes a compile error on one acceptance test file. Gavin is actually fixing them properly, but the intent of the last commit was to stop all the build errors. Co-authored-by: Jonathan Chappelow <jonathan.chappelow@gmail.com>
brennanjl
pushed a commit
that referenced
this pull request
Feb 26, 2024
This adds back a couple of methods on the wrappedSqliteClient in pkg/sql/testing that were there to prevent a panic due to double closing. These were accidentally removed in a previous commit. This also removes an exported function that was mistakenly added in the last commit as well, UnmarshalSchema. There is already a deserialize method that also converts to the engine/type.Schema type. Lastly, it fixes a compile error on one acceptance test file. Gavin is actually fixing them properly, but the intent of the last commit was to stop all the build errors. Co-authored-by: Jonathan Chappelow <jonathan.chappelow@gmail.com>
brennanjl
pushed a commit
that referenced
this pull request
Feb 26, 2024
This adds back a couple of methods on the wrappedSqliteClient in pkg/sql/testing that were there to prevent a panic due to double closing. These were accidentally removed in a previous commit. This also removes an exported function that was mistakenly added in the last commit as well, UnmarshalSchema. There is already a deserialize method that also converts to the engine/type.Schema type. Lastly, it fixes a compile error on one acceptance test file. Gavin is actually fixing them properly, but the intent of the last commit was to stop all the build errors. Co-authored-by: Jonathan Chappelow <jonathan.chappelow@gmail.com>
brennanjl
pushed a commit
that referenced
this pull request
Feb 26, 2024
This adds back a couple of methods on the wrappedSqliteClient in pkg/sql/testing that were there to prevent a panic due to double closing. These were accidentally removed in a previous commit. This also removes an exported function that was mistakenly added in the last commit as well, UnmarshalSchema. There is already a deserialize method that also converts to the engine/type.Schema type. Lastly, it fixes a compile error on one acceptance test file. Gavin is actually fixing them properly, but the intent of the last commit was to stop all the build errors. Co-authored-by: Jonathan Chappelow <jonathan.chappelow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacing #170 since @brennanjl got the ABCI app in a runnable state in #172.
Here I'm just fixing a few things that were either unaddressed by or regressed in #169
This adds back a couple of methods on the wrappedSqliteClient in pkg/sql/testing that were there to prevent a panic due to double closing. These were accidentally removed in a previous commit.
This also removes an exported function that was mistakenly added in the last commit as well, UnmarshalSchema. There is already a deserialize method that also converts to the engine/type.Schema type.
Lastly, it fixes a compile error on one acceptance test file. Gavin is actually fixing them properly, but the intent of the last commit was to stop all the build errors.