Adjust h1 margins so page header border aligns with left nav item #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
/kind bug |
openshift-ci-robot
added
kind/bug
spadgett
approved these changes
Oct 27, 2017
|
/retest |
|
Automatic merge from submit-queue. |
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 1, 2017
Automatic merge from submit-queue. Adjust spacing around 'Events' heading in sidebar on monitoring page In #2389 I adjusted the spacing around the h1 so borders aligned, but I overlooked the border underneath "Events" in the monitoring page sidebar. This fixes that, and does so in a way that the border is consistent across browsers (it wasn't before--only Chrome had a correctly aligned border). Before:  After: 
Merged
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 2, 2017
Automatic merge from submit-queue. Fix bugs with headings More cleanup of bugs I made with #2389. I should have caught these the first two times. But on the up side, that's one more commit for the leaderboard. ;-) Before:    After:   
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The misalignment of the page-header bottom border and the left nav divider bugs me.
It's better to have them align?