Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken route links #2445

Merged

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Nov 2, 2017

Noticed a couple of broken links to docs for routes.

@spadgett
Copy link
Member

spadgett commented Nov 2, 2017

/kind bug
/lgtm
/hold

Holding for @jwforres approval, but this is probably a blocker.

@jwforres
Copy link
Member

jwforres commented Nov 2, 2017

yup
/hold cancel

but @sg00dwin can you do a pass on the rest of the links and make sure they are still good

@jwforres
Copy link
Member

jwforres commented Nov 2, 2017

@ahardin-rh there are at least two cases here where doc links are broken, these should have at least had redirects put in place

@sg00dwin
Copy link
Member Author

sg00dwin commented Nov 2, 2017

@spadgett
Copy link
Member

spadgett commented Nov 3, 2017

/kind bug
/lgtm

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Nov 3, 2017
@spadgett
Copy link
Member

spadgett commented Nov 3, 2017

/test

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit f4af210 into openshift:master Nov 3, 2017
@sg00dwin sg00dwin deleted the broken-route-links branch November 6, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants