Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable RBAC create commands #15618

Merged

Conversation

fabianofranz
Copy link
Member

@fabianofranz fabianofranz commented Aug 2, 2017

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1476166

For the release-3.6 branch.

Disables oc create clusterrole|clusterrolebinding|role|rolebinding until we allow users to control Kube RBAC objects (3.7).

@openshift-merge-robot openshift-merge-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 2, 2017
@fabianofranz
Copy link
Member Author

PTAL @liggitt @simo5 @enj

@enj
Copy link
Contributor

enj commented Aug 2, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2017
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2017
@fabianofranz fabianofranz added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2017
@0xmichalis
Copy link
Contributor

/retest

@mrogers950
Copy link
Contributor

/lgtm

@0xmichalis
Copy link
Contributor

/retest

1 similar comment
@fabianofranz
Copy link
Member Author

/retest

@liggitt
Copy link
Contributor

liggitt commented Sep 1, 2017

/approve
fix the PR description... modifying RBAC objects is in 3.7, not in 3.6.1

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, fabianofranz, liggitt, mrogers950

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 42b4710 into openshift:release-3.6 Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants