Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 58685: Fill size attribute for the OpenStack V3 API volumes #18237

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

tsmetana
Copy link
Member

The getVolume method in OpenStack provider is not filling the Size for the V3 API type volumes. This
breaks the PV resizing of Cinder volumes which compares the existing volume size with the new request. This leads to redundant volume resize calls to the cloud provider that end with errors.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535314

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Jan 23, 2018
@gnufied
Copy link
Member

gnufied commented Jan 23, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2018
@tsmetana
Copy link
Member Author

/retest

@childsb
Copy link
Contributor

childsb commented Feb 1, 2018

/approve

@tsmetana
Copy link
Member Author

tsmetana commented Feb 5, 2018

@smarterclayton can you please take a look an approve eventually? Thanks

@tsmetana
Copy link
Member Author

tsmetana commented Feb 9, 2018

@mfojtik sorry to bother, but can you approve this please?

@mfojtik
Copy link
Contributor

mfojtik commented Feb 9, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2018
@mfojtik
Copy link
Contributor

mfojtik commented Feb 9, 2018

/approve no-issue

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, gnufied, mfojtik, tsmetana

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@tsmetana
Copy link
Member Author

Flake #12629

@tsmetana
Copy link
Member Author

/retest

2 similar comments
@tsmetana
Copy link
Member Author

/retest

@tsmetana
Copy link
Member Author

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2018

@tsmetana: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration cbdbd28 link /test integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18237, 18586, 18578).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants