start tightening scheme usage in oc #20385
Merged
+789
−852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
/retest |
mfojtik
reviewed
Jul 23, 2018
| if [[ "$(du -m "${OS_OUTPUT_BINPATH}/${platform}/oc" | cut -f 1)" -gt "115" ]]; then | ||
| os::log::fatal "oc binary has grown substantially. You must have approval before bumping this limit." | ||
| ocsize=$(du -m "${OS_OUTPUT_BINPATH}/${platform}/oc" | cut -f 1) | ||
| if [[ "${ocsize}" -gt "116" ]]; then |
There was a problem hiding this comment.
+1MB ? :-))
Yeah, we were missing an api group.
mfojtik
reviewed
Jul 23, 2018
| @@ -31,6 +31,15 @@ import ( | |||
| "github.com/openshift/origin/pkg/user/apis/user" | |||
| ) | |||
|
|
|||
| func IsOAPI(gvk schema.GroupVersionKind) bool { | |||
There was a problem hiding this comment.
I would maybe put a DEPRECATED label here.
There was a problem hiding this comment.
I would maybe put a DEPRECATED label here.
done
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
New changes are detected. LGTM label has been removed. |
deads2k
added
lgtm
|
New changes are detected. LGTM label has been removed. |
|
/retest |
1 similar comment
|
/retest |
juanvallejo
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on previous scheme installation fixes and printing protections to start collapsing onto the external only scheme in kubectl for reading and printing. It also fixes the upstream internally versioned commands which we inadvertently broke. We're winning!
/assign @juanvallejo @soltysh @mfojtik