RPMS - Add stub /etc/sysconfig/origin-node #20717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
requested review from
sjenning,
smarterclayton and
vrutkovs
openshift-ci-robot
added
the
size/XS
sdodson
force-pushed
the
restore-sysconfig-file
branch
from
b7b2d38
to
26439bc
Compare
sdodson
force-pushed
the
restore-sysconfig-file
branch
from
26439bc
to
c5db4a5
Compare
sdodson
force-pushed
the
restore-sysconfig-file
branch
from
c5db4a5
to
f5c0d60
Compare
openshift-ci-robot
added
size/M
sdodson
force-pushed
the
restore-sysconfig-file
branch
from
f5c0d60
to
f1fe533
Compare
openshift-ci-robot
added
size/XS
sdodson
changed the title
Previously we'd removed this file from the RPM, however that resulted in the file being removed during upgrades which altered configuration on running systems
sdodson
force-pushed
the
restore-sysconfig-file
branch
from
f1fe533
to
f4ea5eb
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is wholely managed by openshift-ansible. However if we remove
the file from the RPM entirely then that will delete the file during
upgrades to the newer version. So leave the file in the package with
empty contents. The %config(noreplace) directive will ensure that RPM
doesn't replace local modifications when upgrading.
/cc @sjenning @vrutkovs @smarterclayton
Supersedes #20683