Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br need to retry scatter if reply status is not SUCCESS #47236

Closed
Leavrth opened this issue Sep 25, 2023 · 6 comments · Fixed by #46471
Closed

br need to retry scatter if reply status is not SUCCESS #47236

Leavrth opened this issue Sep 25, 2023 · 6 comments · Fixed by #46471
Labels
affects-6.5 affects-7.1 affects-7.5 component/br This issue is related to BR of TiDB. severity/major type/bug This issue is a bug.

Comments

@Leavrth
Copy link
Contributor

Leavrth commented Sep 25, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

br sends scatter request, and pd returns CANCEL response.

2. What did you expect to see? (Required)

br retries to send the request

3. What did you see instead (Required)

br ignores it.

4. What is your TiDB version? (Required)

master
@Leavrth Leavrth added the type/bug This issue is a bug. label Sep 25, 2023
@Leavrth
Copy link
Contributor Author

Leavrth commented Sep 25, 2023

/component br

@ti-chi-bot ti-chi-bot bot added the component/br This issue is related to BR of TiDB. label Sep 25, 2023
@Leavrth Leavrth mentioned this issue Sep 25, 2023
Merged
12 tasks
@Leavrth
Copy link
Contributor Author

Leavrth commented Sep 25, 2023

/severity major

@ti-chi-bot ti-chi-bot bot added severity/major may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Sep 25, 2023
@Leavrth
Copy link
Contributor Author

Leavrth commented Sep 26, 2023

/affects-7.1

@Leavrth
Copy link
Contributor Author

Leavrth commented Sep 26, 2023

/label affects-6.5
/label affects-7.1
/remove-label may-affects-*

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2023

@Leavrth: The label(s) may-affects-* cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, require-LGT3, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, needs-cherry-pick-release-6.6, needs-cherry-pick-release-7.0, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.2, needs-cherry-pick-release-7.3, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, affects-6.6, affects-7.0, affects-7.1, affects-7.2, affects-7.3, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5, may-affects-6.6, may-affects-7.0, may-affects-7.1, may-affects-7.2, may-affects-7.3.

In response to this:

/label affects-6.5
/label affects-7.1
/remove-label may-affects-*

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Sep 26, 2023

/remove-label may-affects-5.3
/remove-label may-affects-5.4
/remove-label may-affects-6.1

@ti-chi-bot ti-chi-bot bot removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Sep 26, 2023
ti-chi-bot bot pushed a commit that referenced this issue Nov 7, 2023
@Leavrth
br: retry to scatter the regions if status is timeout or cancel (#46471)
0abd132 
close #47236
This was referenced Nov 7, 2023
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 8, 2023
@ti-chi-bot
br: retry to scatter the regions if status is timeout or cancel (#46471…
48449e3 
…) (#48376)

close #47236
ti-chi-bot bot pushed a commit that referenced this issue Nov 24, 2023
@ti-chi-bot
br: retry to scatter the regions if status is timeout or cancel (#46471…
08b1bd3 
…) (#48377)

close #47236
ti-chi-bot bot pushed a commit that referenced this issue Dec 7, 2023
@ti-chi-bot
br: retry to scatter the regions if status is timeout or cancel (#46471…
159547b 
…) (#48378)

close #47236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 affects-7.5 component/br This issue is related to BR of TiDB. severity/major type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: retry to scatter the regions if status is timeout or cancel Leavrth/tidb
2 participants
@Leavrth @ti-chi-bot