Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prompt not accurate when br restore with non-compatible system table #50240

Closed
fubinzh opened this issue Jan 10, 2024 · 1 comment · Fixed by #50242
Closed

prompt not accurate when br restore with non-compatible system table #50240

fubinzh opened this issue Jan 10, 2024 · 1 comment · Fixed by #50242
Labels
affects-7.6 component/br This issue is related to BR of TiDB. severity/moderate type/bug This issue is a bug.

Comments

@fubinzh
Copy link

fubinzh commented Jan 10, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. run br restore to restore full backup of previous version of tidb cluster, which has uncompatible system tables.

2. What did you expect to see? (Required)

  1. Restore should failed, with accurate prompt to let me to skip restore of system table.

3. What did you see instead (Required)

There prompt "you can remove 'with-sys-table' flag to skip restoring system tables" is not accurate, I need to specify --with-sys-table=false explicitely.

image

4. What is your TiDB version? (Required)

br v7.6.0
@fubinzh fubinzh added the type/bug This issue is a bug. label Jan 10, 2024
@fubinzh
Copy link
Author

fubinzh commented Jan 10, 2024

/component br
/severity moderate

@ti-chi-bot ti-chi-bot bot added component/br This issue is related to BR of TiDB. severity/moderate labels Jan 10, 2024
@BornChanger BornChanger mentioned this issue Jan 10, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 15, 2024
@BornChanger
br: fix the --with-sys-table prompt (#50242)
1a34fe6 
close #50240
@ti-chi-bot ti-chi-bot mentioned this issue Jan 15, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 15, 2024
@ti-chi-bot
br: fix the --with-sys-table prompt (#50242) (#50436)
42960c3 
close #50240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.6 component/br This issue is related to BR of TiDB. severity/moderate type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: fix the --with-sys-table prompt BornChanger/tidb
2 participants
@fubinzh @ti-chi-bot