Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

stage0: fix message formatting errors, stale forward-vars #3722

Merged
merged 2 commits into from
Jun 20, 2017
Merged

stage0: fix message formatting errors, stale forward-vars #3722

merged 2 commits into from
Jun 20, 2017

Conversation

glevand
Copy link
Contributor

@glevand glevand commented Jun 19, 2017

No description provided.

Use the path string not the os.File object when formatting error messages.

Fixes errors like these when building with go1.9:

  common/common.go: arg dir for printf verb %q of wrong type: *os.File

Signed-off-by: Geoff Levand <geoff@infradead.org>
This target no longer uses ABS_GO, so remove the forward-vars for
it.

Signed-off-by: Geoff Levand <geoff@infradead.org>
Copy link
Member

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucab lucab added this to the 1.28.0 milestone Jun 20, 2017
@lucab lucab changed the title Fix message formatting errors, stale forward-vars stage0: fix message formatting errors, stale forward-vars Jun 20, 2017
@lucab lucab merged commit ac7f458 into rkt:master Jun 20, 2017
@glevand glevand deleted the for-merge-format branch June 20, 2017 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants