This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt: prevent skipping some images in image gc #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using break when we found an image with a pod in running state but that means we'll miss subsequent images for non-running pods. Change the break to a continue to keep processing the rest.
This was referenced Nov 21, 2017
Closed
|
lgtm |
naveens
added a commit
to naveens/ansible-coreos-setup
that referenced
this pull request
Apr 25, 2018
Includes oneshot service to download custom rkt executable. This is required to get rkt-1.30+ (which is not yet packaged in CoreOS stable) that comes with a bugfix for rkt/rkt#3858
naveens
added a commit
to vmware-archive/ansible-coreos-setup
that referenced
this pull request
May 3, 2018
Includes oneshot service to download custom rkt executable. This is required to get rkt-1.30+ (which is not yet packaged in CoreOS stable) that comes with a bugfix for rkt/rkt#3858
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using break when we found an image with a pod in running state
but that means we'll miss subsequent images for non-running pods.
Change the break to a continue to keep processing the rest.