Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

rkt: add AWS auth headerer support to rkt config #3910

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Conversation

rufoa
Copy link
Contributor

@rufoa rufoa commented Mar 21, 2018

This refactors awsAuthHeaderer to match oAuthBearerTokenHeaderer and modifies
the config command so awsAuthHeaderer can be marshaled to JSON (support for
this was previously missing).

This refactors awsAuthHeaderer to match oAuthBearerTokenHeaderer and modifies
the `config` command so awsAuthHeaderer can be marshaled to JSON (support for
this was previously missing).
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

I manually tested that fetching from an s3 bucket works fine still with this since I don't think we have test coverage there

@euank euank merged commit 0a78bb8 into rkt:master Mar 27, 2018
@iaguis iaguis added this to the 1.30.0 milestone Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants