dont parse subrepo package again if the subrepo label subrepo is the same as the dependent subrepo #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goddenrich
force-pushed
the
error-when-subrepo-doesnt-exist
branch
from
047d7ef
to
7d5f5f8
Compare
peterebden
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
LGTM.
I don't have a lot of insight into why it fixes the hang - possibly it makes it parse subrepos less often so that case doesn't come up. @Tatskaari is more familiar with that bit than I am these days though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were maybeParseSubrepoPackage for the host repo and if we don't find the subrepo we would check in the dependent label's subrepo. This is unnecessary if the dependent label's subrepo is the same as the host repo.
There is also a bug which this fixes where we indefinitely wait on parsing a subrepo if the subrepo doesn't exist. This change should just be an optimisation but it fixes the bug too.