Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting adapter nodeSelector #1380

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Add support for setting adapter nodeSelector #1380

merged 4 commits into from
Mar 28, 2023

Conversation

FranBarrera
Copy link
Contributor

Addresses one of the features requested in #768.

Example:

spec:
  # ...
  adapterOverrides:
    nodeSelector:
      disktype: ssd

Result:

kubectl get deployment awss3source-sample -o jsonpath='{.spec.template.spec.nodeSelector}'
{"disktype":"ssd"}

@FranBarrera FranBarrera requested a review from a team March 28, 2023 11:09
@FranBarrera FranBarrera self-assigned this Mar 28, 2023
odacremolbap
odacremolbap reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@odacremolbap odacremolbap left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested by the action output, can you you did it before I wrote this ...

hack/crd-update/update-all-crds.sh

pkg/reconciler/resource/deployment_test.go Show resolved Hide resolved
@odacremolbap odacremolbap self-requested a review March 28, 2023 11:30
odacremolbap
odacremolbap approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@odacremolbap odacremolbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy when CI is happy.

@FranBarrera FranBarrera merged commit bc1032f into triggermesh:main Mar 28, 2023
@FranBarrera FranBarrera deleted the add-nodeselector branch March 28, 2023 14:24
@sebgoa sebgoa mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odacremolbap odacremolbap odacremolbap approved these changes

Assignees

@FranBarrera FranBarrera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FranBarrera @odacremolbap